Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check links on EOL banner #16990

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

check links on EOL banner #16990

wants to merge 1 commit into from

Conversation

pondrejk
Copy link
Contributor

Problem Statement

EOL banner takes a long time to show up (half year before EOL), links contained in the banner can become outdated

Solution

Add checks that links work

Related Issues

awaits SAT-29427
needs
SatelliteQE/airgun#1644

@pondrejk pondrejk added AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Nov 22, 2024
@pondrejk pondrejk self-assigned this Nov 22, 2024
@pondrejk pondrejk requested a review from a team as a code owner November 22, 2024 13:39
@pondrejk pondrejk marked this pull request as draft November 22, 2024 13:39
lhellebr
lhellebr approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this can't be merged because the feature hasn't been delivered yet, but I can already ACK code-wise, subject to future PRT results.

@LadislavVasina1 LadislavVasina1 added the CherryPick PR needs CherryPick to previous branches label Nov 23, 2024
@pondrejk pondrejk marked this pull request as ready for review December 2, 2024 10:20
@pondrejk pondrejk removed Do Not Merge 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Dec 2, 2024
@pondrejk
Copy link
Contributor Author

pondrejk commented Dec 2, 2024 

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py -k e2e
nailgun: 1644

@pondrejk
Copy link
Contributor Author

pondrejk commented Dec 2, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_eol_banner.py
nailgun: 1644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@lhellebr lhellebr lhellebr approved these changes

Assignees

@pondrejk pondrejk

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pondrejk @lhellebr @LadislavVasina1